Merged
Conversation
DavideIadeluca
requested changes
Dec 2, 2025
Member
There was a problem hiding this comment.
As you mentioned I think we need a migration here (especially considering the pending 1.x implementation) which:
- If
Select own postdisabled, nothing needs to be done (admin by default, fully preserves backwards compatibility) - If
Select own postenabled, grant member permissions globally and optionally on all tag scopes (should also be fully backwards compatible)
Also it appears like a change in the condition of adding the frontend controls are needed as currently the controls are added whilst the backend returns a 403 response:
Screen.Recording.2025-12-02.at.09.40.04.mov
Member
Author
|
Thanks for testing @DavideIadeluca - I've not added the migration yet, but the permission issue you identified is now resolved locally for me. Can you please confirm? |
DavideIadeluca
requested changes
Dec 2, 2025
Member
DavideIadeluca
left a comment
There was a problem hiding this comment.
The previous issue is now resolved, but now it appears like a new issue is introduced with unselecting a best answer (with permitted users):
Screen.Recording.2025-12-02.at.13.06.46.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Removes the previous
Select own post as best answersetting and replaces it with tag scoped permissions, to allow for finer control over which users can perform this actionReviewers should focus on:
Note the translation key change from
fof-best-answer.admin.settings.allow_select_own_posttofof-best-answer.admin.permissions.allow_select_own_postScreenshot
Confirmed
composer test).Required changes: