fix-move-select-own-post-to-permission: Fix to move the bestAnswer se…#123
Closed
grimur82 wants to merge 12 commits intoFriendsOfFlarum:1.xfrom
Closed
fix-move-select-own-post-to-permission: Fix to move the bestAnswer se…#123grimur82 wants to merge 12 commits intoFriendsOfFlarum:1.xfrom
grimur82 wants to merge 12 commits intoFriendsOfFlarum:1.xfrom
Conversation
…lect own post 1. User who picks a best answer with own post is now based on group permission 2. Added releated test cases 3. Moved/Removed releveant translations 4. Attributes for permission is now found in post attributes Reported by: Grimur Vid Neyst Signed off by: Grimur Vid Neyst <grimur.vid-neyst@glowingblue.com>
added 2 commits
December 3, 2025 09:32
Fixed styling according to styleCI Reported by: Grimur Vid Neyst Signed off by: Grimur Vid Neyst <grimur.vid-neyst@glowingblue.com>
Reported by: Grimur Vid Neyst Signed off by: Grimur Vid Neyst <grimur.vid-neyst@glowingblue>
DavideIadeluca
requested changes
Dec 3, 2025
Member
DavideIadeluca
left a comment
DavideIadeluca
left a comment
There was a problem hiding this comment.
Similar feedback like in #124 (review). One issue we have in the frontend is that if the permission to select own posts is set to admins, that members still see the control to select a own post even when the backend returns a 403:
Screen.Recording.2025-12-03.at.14.38.36.mov
Besides that this PR looks mostly okay 👍 Some CI issues need to be resolved though
added 3 commits
December 4, 2025 10:37
Member
|
Closing this in favor of #127 |
DavideIadeluca
deleted the
gvn/fix-move-select-own-post-to-permission
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lect own post
Reported by: Grimur Vid Neyst
Signed off by: Grimur Vid Neyst grimur.vid-neyst@glowingblue.com
Fixes #0000
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Confirmed
composer test).Required changes: