Skip to content

Validate that time property is valid and not in the future #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Validate that time property is valid and not in the future #749

merged 1 commit into from
Apr 10, 2025

Conversation

glaubinix
Copy link
Contributor

Following #748

Validates that:

  • if time is provided as a string that it can be parsed by PHP
  • the provided time isn't in the future (which isn't possible as the time references an existing commit)

@stof stof merged commit 2f761bf into master Apr 10, 2025
2 checks passed
@stof stof deleted the validator-validate-time-property branch April 10, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naderman naderman naderman approved these changes

@stof stof stof approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glaubinix @naderman @stof @xabbuh