feat: Support SW6.7 #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please note, proposed code requires Shopware 6.7 (not Shopware 6.6 as it is used in the pipeline) |
|
@tinect Can we get support for SW 6.7 please? |
src/Resources/views/storefront/component/compare/offcanvas-product.html.twig
Outdated
Show resolved
Hide resolved
Refactor handling Ajax request in frontend.compare.offcanvas Refactor getting reviews details in frontend.compare.page Replace seoUrl twig function by path to make link work
Fix composer requirements for shopware
Decode `$productIds` in /compare/offcanvas as associative array, set max depth and throw an exception on wrong json structure. Co-authored-by: Felix Schneider <[email protected]>
schneider-felix
force-pushed
the
feat/refactor-to-support-sw67
branch
from
9c934c7 to
be12376
Compare
|
Hi, just checking in to see if there are any updates on this PR. Thanks! |
tinect
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor handling Ajax request in frontend.compare.offcanvas
Refactor getting reviews details in frontend.compare.page
Replace seoUrl twig function by path to make link work