Skip to content

Conversation

@sat-hub
Copy link

@sat-hub sat-hub commented Sep 2, 2025

This fixes issue #54. I took the patch by @stigfaerch for 8.2.2 and applied it to the master branch.

@sat-hub
Copy link
Author

sat-hub commented Sep 8, 2025

Correction: The patch is originally made by @TimWilms, see #56.

@stigfaerch
Copy link
Contributor

@sat-hub
When comparing your patch with the on made by @TimWilms, there is many more changes in the one of Tims:
8.2.2...TimWilms:jumpurl:8.2.2-fix
Any idea what that is all about?

@sat-hub
Copy link
Author

sat-hub commented Sep 9, 2025

Of course - these are just additional whitespaces because he added an additional if-then, which increases the indentation of many lines.
I thought that this is quite unnecessary and made the diff much larger than it must be, so I changed the additional if to a boolean condition $isFrontendRequest and added it to the existing if, which results in only one additional line of code and one changed line of code - much shorter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants