Skip to content

[TASK] User can choose existing sets to create setting definition #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linawolf merged 2 commits into from
Feb 1, 2026
Merged

[TASK] User can choose existing sets to create setting definition #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6805ff0
[TASK] User can choose existing sets to create setting definition
linawolf Feb 1, 2026
3ed8dbc
[TASK] User can choose existing sets to create setting definition
linawolf Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 30 additions & 37 deletions Classes/Command/SiteSettingsDefinitionCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use FriendsOfTYPO3\Kickstarter\Command\Input\Question\ChooseExtensionKeyQuestion;
use FriendsOfTYPO3\Kickstarter\Command\Input\QuestionCollection;
use FriendsOfTYPO3\Kickstarter\Context\CommandContext;
use FriendsOfTYPO3\Kickstarter\Information\ExtensionInformation;
use FriendsOfTYPO3\Kickstarter\Information\SiteSetInformation;
use FriendsOfTYPO3\Kickstarter\Information\SiteSettingsDefinitionInformation;
use FriendsOfTYPO3\Kickstarter\Service\Creator\SiteSettingsDefinitionCreatorService;
Expand Down Expand Up @@ -79,57 +80,51 @@ protected function execute(InputInterface $input, OutputInterface $output): int
'Now, we will ask you a few questions to customize the siteSet according to your needs.',
'Please take your time to answer them.',
]);

$siteSettingsDefinitionInformation = $this->askForSiteSettingsDefinitionInformation($commandContext);
$extensionInformation = $this->getExtensionInformation(
(string)$this->questionCollection->askQuestion(
ChooseExtensionKeyQuestion::ARGUMENT_NAME,
$commandContext,
),
$commandContext
);
if (count($extensionInformation->getSets()) < 1) {
$io->warning('Extension ' . $extensionInformation->getExtensionKey() . ' contains no site set yet. Use command typo3 make:site-set to create a site set first.');
return Command::FAILURE;
}
$siteSettingsDefinitionInformation = $this->askForSiteSettingsDefinitionInformation($commandContext, $extensionInformation);
$this->siteSettingsDefinitionCreatorService->create($siteSettingsDefinitionInformation);
$this->printCreatorInformation($siteSettingsDefinitionInformation->getCreatorInformation(), $commandContext);

return Command::SUCCESS;
}

private function askForSiteSettingsDefinitionInformation(CommandContext $commandContext): SiteSettingsDefinitionInformation
{
private function askForSiteSettingsDefinitionInformation(
CommandContext $commandContext,
ExtensionInformation $extensionInformation
): SiteSettingsDefinitionInformation {
$io = $commandContext->getIo();
$extensionInformation = $this->getExtensionInformation(
(string)$this->questionCollection->askQuestion(
ChooseExtensionKeyQuestion::ARGUMENT_NAME,
$commandContext,
),
$commandContext

$siteSet = new SiteSetInformation(
$extensionInformation,
'',
$this->askForSiteSetPath($commandContext, $extensionInformation),
);

return new SiteSettingsDefinitionInformation(
$extensionInformation,
new SiteSetInformation(
$extensionInformation,
'',
$this->askForSiteSetPath($io),
),
$siteSet,
$categories = $this->askForCategories($io),
$this->askForSettings($io, $categories),
);
}

private function askForSiteSetPath(SymfonyStyle $io): string
{
$default = '';
do {
$siteSetPath = $io->ask('Please enter the site set directory name (must exist)', $default);

if ($siteSetPath === null) {
$io->error('The site set path cannot be empty.');
continue;
}

if (preg_match('~[\\\\/]~', $siteSetPath)) {
$io->error('The site set path must not contain slashes.');
continue;
}

// Valid input
return $siteSetPath;

} while (true);
private function askForSiteSetPath(
CommandContext $commandContext,
ExtensionInformation $extensionInformation
): string {
$io = $commandContext->getIo();
$sets = $extensionInformation->getSets();
return $io->choice('Choose the site set', $sets, $sets[0]);
}

private function askForCategories(SymfonyStyle $io): array
Expand All @@ -140,8 +135,6 @@ private function askForCategories(SymfonyStyle $io): array
$io->writeln('You must enter at least one category.');

do {

// --- Key ---
$key = $io->ask(
'Enter category key (alphanumeric and dots allowed, e.g., BlogExample.pages)',
null,
Expand Down