fix: resolve cross-workspace IDOR in workspace management endpoints#47
Merged
Conversation
Use getWorkspace(request) to scope GET/PUT/DELETE operations to the authenticated workspace instead of accepting arbitrary workspaceId from URL params. This matches the secure pattern used by events and webhooks controllers. Closes #46 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspaceIdfrom URL params, allowing any authenticated admin to read/update/delete other workspaces@Param('workspaceId')withgetWorkspace(request)on GET, PUT, and DELETE endpoints to scope operations to the authenticated workspace:workspaceIdpath parameter from routes — operations now implicitly target the caller's workspace, matching the pattern used by events and webhooks controllersCloses #46
Test plan