Skip to content

Conversation

@jackmoxley
Copy link
Contributor

Adding the choatic lab cnc probe, which has a higher threshold as it is more prone to failure on gantry checking and height maps.

It used the base voron_tap, so all the macros and pin settings remain.

@EricZimmerman
Copy link
Contributor

Why is this needed vs just straight up overriding the [probe] block?

# Conflicts:
#	config/hardware/probes/chaoticlab-cnc-tap-v2.cfg
@jackmoxley
Copy link
Contributor Author

Why is this needed vs just straight up overriding the [probe] block?

I did exactly that, but in the nature of providing out the box support for everyone that uses these mods, I thought it would be helpful.

You could say the same thing about anny klippain config file.

@github-actions
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

1 similar comment
@github-actions
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Copy link
Owner

@Frix-x Frix-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR!

I'm all for it. It's part of the work I wanted to do to make more probes easily available without having to put the offsets in the overrides every time. So this might be a good candidate for a first file like this.

Eric, the goal would be to be able to select with Klicky, Euclid, etc... instead of "dockable", since not all dockable probes are similar. But they will all reference this dockable probe file under the hood with the added customizations.

However, @jackmoxley can you add the entry in the printer.cfg file to be able to select it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants