Website redesign & various changes - #39
Open
NovaDev404 wants to merge 14 commits into
Open
Conversation
…cessfully signed certificates and remove IPA/plist pairs for certificates that are no longer in the signing pool. This prevents stale entries from appearing as Status unknown on the generated page.
Author
|
There was a problem hiding this comment.
🟡 Changes recommended
There are security-sensitive link/ownership inconsistencies in generated install artifacts plus a confirmed env-var bug in the signing script that can overwrite the wrong file.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refreshes the SideInstaller install site styling and augments the signing + page-generation pipeline to include certificate revocation status and to clean up stale signed artifacts.
Changes:
- Introduces a new design token system (
tokens.css) and updated site/legal styles (site.css,legal.css), wired intoindex.html,beta.html,terms.html, and the HTML template. - Adds certificate status (signed/revoked/unknown) into signing metadata and renders it in the generated certificate cards (including sort order by status).
- Adds stale signed artifact pruning to the signing flow and updates various published links (notably to sideinstaller.net).
File summaries
| File | Description |
|---|---|
| tokens.css | Adds shared design tokens (colors, typography, spacing, motion). |
| site.css | New site-wide styling for the main install pages (index/beta). |
| legal.css | New styling for long-form legal pages (terms). |
| terms.html | Switches to local app icon and includes legal.css. |
| scripts/template.html | Adds site.css to the generated page template. |
| scripts/sign_with_all_certs.sh | Adds certificate status fetching, writes status to metadata/state, and prunes stale outputs. |
| scripts/generate_index.sh | Reads status from metadata, adds a status pill, and sorts certificates by status. |
| README.md | Updates the official website link to sideinstaller.net. |
| index.html | Updated generated install page (new CSS + status pills + updated links/artifacts). |
| beta.html | Updated generated beta page (new CSS, local icon, status sorting). |
| .github/workflows/sign-sideinstaller.yml | Expands triggers and deploys CSS/icon assets to Pages. |
| .github/workflows/plist-and-index.yml | Deploys CSS/icon assets to Pages. |
| output/sign-state.tsv | Updates recorded state format/values (including status + updated URLs). |
| output/certificate-validity.tsv | Adds status column and updates entries accordingly. |
| output/sideinstaller-Aramco.plist | Updates embedded IPA URL. |
| output/sideinstaller-BOC.plist | Updates embedded IPA URL. |
| output/sideinstaller-Beijing-Xibei-Longzhimeng-Restaurant-Management-Co.-Ltd.plist | Updates embedded IPA URL. |
| output/sideinstaller-CENTRAL-POWER-INFORMATION-TECHNOLOGY-COMPANY-CENTRAL-POWER-CORPORATION-com.cpc.it.thinghiemdien.plist | Updates embedded IPA URL. |
| output/sideinstaller-China-National-Heavy-Duty-Truck-Group-Co.-Ltd.plist | Updates embedded IPA URL. |
| output/sideinstaller-China-National-Heavy-Duty-Truck-Group-Co.-Ltd..plist | Updates embedded IPA URL. |
| output/sideinstaller-China-Telecom-Corporation-Limited-XC-com-ctq-qmc-yiban-inde.plist | Updates embedded IPA URL. |
| output/sideinstaller-ChinaAcademy.plist | Updates embedded IPA URL. |
| output/sideinstaller-ChinaPower.plist | Updates embedded IPA URL. |
| output/sideinstaller-Election.plist | Updates embedded IPA URL. |
| output/sideinstaller-Forever.plist | Updates embedded IPA URL. |
| output/sideinstaller-Guangzhou-Huahan-Educational-Technology-Co.-Ltd.plist | Updates embedded IPA URL. |
| output/sideinstaller-Guangzhou-Huahan-Educational-Technology-Co.-Ltd..plist | Updates embedded IPA URL. |
| output/sideinstaller-Jiangsu-Simcere-Pharmaceutical-Co.-Ltd-workone.plist | Updates embedded IPA URL. |
| output/sideinstaller-Moving-Increasingly-Interconnected-Technology-Co.-Ltd-com.oa11.plist | Updates embedded IPA URL. |
| output/sideinstaller-National.plist | Updates embedded IPA URL. |
| output/sideinstaller-Postal.plist | Updates embedded IPA URL. |
| output/sideinstaller-Rural.plist | Updates embedded IPA URL. |
| output/sideinstaller-Takeoff.plist | Updates embedded IPA URL. |
| output/sideinstaller-Tianjin-University-of-Commerce.plist | Updates embedded IPA URL. |
| output/sideinstaller-VIETNAM-AIRLINES-JSC-MOPLUS-LIDO-UAT.plist | Updates embedded IPA URL. |
| output/sideinstaller-VIETNAM-JOINT-STOCK-COMMERCIAL-BANK-FOR-INDUSTRY-AND-TRADE.plist | Updates embedded IPA URL. |
| output/sideinstaller-Vietnam.plist | Updates embedded IPA URL. |
| output/sideinstaller-Viet-Nam-Rubber-Group-Limited.plist | Updates embedded IPA URL. |
| output/sideinstaller-Wuling.plist | Updates embedded IPA URL. |
| output/sideinstaller-XL.plist | Updates embedded IPA URL. |
| output/sideinstaller-HSBC-Bank-plc.plist | Removes the manual HSBC manifest (now sourced via API). |
| certs/HSBC Bank plc/password.txt | Removes the manual HSBC password file (no longer needed). |
Review details
- Files reviewed: 42/63 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
61
to
+62
| TMP_DIR="$(mktemp -d)" | ||
| SIGNED_NAME_LIST_FILE="${CERT_NAME_LIST_FILE:-$TMP_DIR/signed-cert-names.txt}" |
| </div> | ||
| <div class="links repo"> | ||
| <a class="link-btn ipa" href="https://github.com/FrizzleM/SideInstaller/releases/latest/download/SideInstaller.ipa" download rel="noopener"> | ||
| <a class="link-btn ipa" href="https://github.com/NovaDev404/SideInstaller/releases/latest/download/SideInstaller.ipa" download rel="noopener"> |
Comment on lines
+5
to
+8
| ipa_url https://github.com/NovaDev404/SideInstaller/releases/download/v0.9.0/SideInstaller.ipa | ||
| ipa_size 7908297 | ||
| output_base_url https://raw.githubusercontent.com/FrizzleM/SideInstaller/main/output | ||
| inputs_sha256 4ec0668d5d24294f505f0479b7bd186438291b0c86f3f540c05175df43e43643 | ||
| cert Aramco 7E5CF3F26B293474757B449DF5FBFFAF0816D2F7 2026-09-24 | ||
| cert BOC 7E869FF0566ABD14D4D134191EE9D95DA21EC905 2026-11-06 | ||
| cert Beijing A3ABDAD2AC280704A095E4B62FF7ABFFFC7C10E6 2026-08-22 | ||
| cert CENTRAL-POWER-INFORMATION-TECHNOLOGY-COMPANY-CENTRAL-POWER-CORPORATION-com.cpc.it.thinghiemdien C482649E7CD9FBB174DA0045F1CD5C3686D5E84C 2028-11-02 | ||
| cert China-Telecom-Corporation-Limited-XC-com-ctq-qmc-yiban-inde 34591EF5246C536DE31B53F6B542F2A451B030AD 2029-02-23 | ||
| cert ChinaAcademy 4201B4662173FBEE7B8713990551BC6873211DC0 2028-10-27 | ||
| cert ChinaPower 06C1A46DACAA1CE46F8B6D9AA215D76630CC74C7 2028-10-21 | ||
| cert Election 42FE6417695C53C61EC253B84FB5F513CDCCDB05 2028-04-27 | ||
| cert Forever 1D3D1CF7510D64F811A19E199D3A3BDAA064D0D1 2027-02-05 | ||
| cert HSBC-Bank-plc D45C911EC45A3D7DFAA026FF45583E594CF0B8CD 2028-04-29 | ||
| cert Jiangsu-Simcere-Pharmaceutical-Co.-Ltd-workone 121FAB5BFCF826AD1FCE426D8BEFB28B72DE32FD 2028-03-06 | ||
| cert Moving-Increasingly-Interconnected-Technology-Co.-Ltd-com.oa11 7BB04D6421B72EB025C31FE10FB1594B0CFF7E73 2029-06-12 | ||
| cert National 20C2DE15CFFB5373DCBE44F59229D623B6FF03C1 2029-01-25 | ||
| cert Postal C209B89E63F9DE5F76654D6CEB67A8192FC85AF6 2028-08-09 | ||
| cert Rural 27413E49E9017DED9898F07771B057052F33D0DD 2028-11-14 | ||
| cert Takeoff 49C0FB57B40E2B5E6D50BD9D56A22EC8F5559457 2028-06-04 | ||
| cert Viet-Nam-Rubber-Group-Limited 0708D9FE769ADE322561D33C080995D9ED186686 2028-10-14 | ||
| cert Vietnam 164D6E57AA5C329D9DA3E5AF63F983CB113751B0 2028-04-21 | ||
| cert Wuling 0C0C496B68A7C7CF12A93D101C4E6FD8B3DF2C16 2027-05-30 | ||
| cert XL DAE4476E22160B0BA19D1B406E8B82D99BC00E00 2029-02-17 | ||
| output_base_url https://raw.githubusercontent.com/NovaDev404/SideInstaller/main/output | ||
| inputs_sha256 e509638e7ef3ce8231e1ac2527176d648a7e04543d184b752d39fe52a731bb55 |
| <string>software-package</string> | ||
| <key>url</key> | ||
| <string>https://raw.githubusercontent.com/FrizzleM/SideInstaller/main/output/sideinstaller-XL.ipa</string> | ||
| <string>https://raw.githubusercontent.com/NovaDev404/SideInstaller/main/output/sideinstaller-XL.ipa</string> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
All NovaDev404/SideInstaller links will be automatically updated by workflow when run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.