Set up docker-compose to replace the startup scripts#25
Open
shitover wants to merge 2 commits intoFuelLabs:masterfrom
Open
Set up docker-compose to replace the startup scripts#25shitover wants to merge 2 commits intoFuelLabs:masterfrom
shitover wants to merge 2 commits intoFuelLabs:masterfrom
Conversation
Fixes FuelLabs#24 Add docker-compose setup to replace startup scripts. * Add `docker-compose.yml` to define services for PostgreSQL, pgAdmin, and migration scripts. * Update `README.md` to include instructions for using `docker compose up` for local development. * Modify `scripts/start_local_server.sh` to remove the call to `scripts/start_local_db.sh` and use `docker-compose.yml` for starting services. * Delete `scripts/start_local_db.sh`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/FuelLabs/forc.pub/issues/24?shareId=XXXX-XXXX-XXXX-XXXX).
|
@shitover is attempting to deploy a commit to the Fuel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the contribution! Before we can merge this, we need @shitover to sign the Fuel Labs Contributor License Agreement. |
sdankel
suggested changes
Feb 18, 2025
Contributor
sdankel
left a comment
sdankel
left a comment
There was a problem hiding this comment.
Hello, thanks for the contribution. The goal here would be to replace both of the start up scripts, so that both postgres and the server itself can be started with docker compose up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Add docker-compose setup to replace startup scripts.
docker-compose.ymlto define services for PostgreSQL, pgAdmin, and migration scripts.README.mdto include instructions for usingdocker compose upfor local development.scripts/start_local_server.shto remove the call toscripts/start_local_db.shand usedocker-compose.ymlfor starting services.scripts/start_local_db.sh.For more details, open the Copilot Workspace session.