Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }, [handleNavigate, logout]); | ||
|
|
||
| if (!!user) { | ||
| if (user) { |
There was a problem hiding this comment.
Just checking if this should be !! to err on the side of caution, or it is safe by the time we get here?
There was a problem hiding this comment.
They're equivalent. It's only a concern if user can be evaluated as falsy in a way other than null/undefined, such as if user is a string or number.
alfiedotwtf
left a comment
alfiedotwtf
left a comment
There was a problem hiding this comment.
I can't really comment on the details of the individual React + CSS changes, but nothing jumps out at me. Apart from my question, no reason to not approve from me.
There was a problem hiding this comment.
nit: We should try avoid !important since it makes it difficult to identify the heirarchy of CSS overrides
There was a problem hiding this comment.
Will address in a future PR
| {/* Main Content - Left Side (changes with tabs) */} | ||
| <Grid item xs={12} md={7} lg={8}> | ||
| {/* Readme Tab */} | ||
| {activeTab === 0 && renderReadmeTab()} |
There was a problem hiding this comment.
nit: rather than conditional rendering based on activeTab index; maybe can put all these rendered components in a list and render using something like tabList[activeTab]
There was a problem hiding this comment.
Will address in a future PR
zees-dev
left a comment
zees-dev
left a comment
There was a problem hiding this comment.
LGTM 👍
As an improvement I do think we should support both light-mode and dark-mode.
Maybe a future PR.
3 participants
Uh oh!
There was an error while loading. Please reload this page.