Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zees-dev
reviewed
Apr 30, 2025
zees-dev
reviewed
Apr 30, 2025
zees-dev
reviewed
Apr 30, 2025
zees-dev
reviewed
Apr 30, 2025
zees-dev
reviewed
Apr 30, 2025
zees-dev
reviewed
Apr 30, 2025
zees-dev
reviewed
Apr 30, 2025
zees-dev
approved these changes
Apr 30, 2025
Contributor
zees-dev
left a comment
There was a problem hiding this comment.
LGTM 👍
A few nits and/or minor issues.
The only potential higher-priority issue is using potentially unsupported/deprecated version node to build in CI - not a blocker though; can be addressed in future PRs.
Contributor
Author
Thanks! I will address your comments in a future PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to migrate the project to Next.js, improve bundle size management, and enhance code quality. Key updates include configuring Next.js, adding a bundle size analysis workflow, and replacing
react-router-domwith Next.js routing. Additionally, ESLint and Prettier configurations were updated to align with the new setup.Migration to Next.js:
next.config.mjsfile with configurations for strict mode, SWC minification, customdistDir, and environment variables (app/next.config.mjs).react-router-domnavigation with Next.js routing (useRouterandrouter.push) in components likePackageDashboardandApp(app/src/features/dashboard/components/PackageDashboard.tsx,app/src/App.tsx). [1] [2]Bundle size management:
.github/workflows/frontend-bundle-size-check.yml).app/scripts/check-bundle-size.js).Code quality improvements:
app/.eslintrc).package.jsonto include Next.js-specific scripts and dependencies, removing unused libraries and adding new ones likecross-envand@next/eslint-plugin-next(app/package.json). [1] [2]Component updates:
use clientdirective to several components to enable client-side rendering with Next.js (app/src/app/page.tsx,app/src/features/detail/components/AbiContent.tsx). [1] [2]AbiContentto dynamically importReactJsonViewfor server-side rendering compatibility (app/src/features/detail/components/AbiContent.tsx).Miscellaneous:
.nextdirectory to.gitignoreto exclude Next.js build artifacts (app/.gitignore)..env.examplewith a new environment variable for the backend API URL (app/.env.example).