Skip to content

feat: testcontainers integration#386

Merged
viraj124 merged 43 commits intomainfrom
viraj124/382-feat-testcontainers-integration
Feb 14, 2025
Merged

feat: testcontainers integration#386
viraj124 merged 43 commits intomainfrom
viraj124/382-feat-testcontainers-integration

Conversation

@viraj124
Copy link
Copy Markdown
Contributor

@viraj124 viraj124 commented Jan 24, 2025

@viraj124 viraj124 requested a review from a team as a code owner January 24, 2025 07:40
@viraj124 viraj124 marked this pull request as draft January 24, 2025 11:12
@viraj124 viraj124 marked this pull request as ready for review January 27, 2025 11:03
Copy link
Copy Markdown
Member

@DefiCake DefiCake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test CIs seem to be failing - commented through internal channels

DefiCake
DefiCake previously approved these changes Feb 13, 2025
let ethereumETHReceiverAddress: string;
let withdrawMessageProof: MessageProof;
let rateLimitDuration: bigint;
// let fuel_signer2: FuelWallet;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Copy Markdown
Contributor

@PraneshASP PraneshASP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, few nits.

@DefiCake DefiCake self-requested a review February 14, 2025 09:23
@viraj124 viraj124 merged commit bc02a46 into main Feb 14, 2025
@viraj124 viraj124 deleted the viraj124/382-feat-testcontainers-integration branch February 14, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(test): switch to testcontainers for integration tests

4 participants