Add unchecked constructors for `FuelClient` by MitchTurner · Pull Request #3183 · FuelLabs/fuel-core

MitchTurner · 2026-01-21T21:42:34Z

Linked Issues/PRs

Closes #3176

Description

Checklist

Breaking changes are clearly marked as such in the PR description and changelog
New behavior is reflected in tests
The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

I have reviewed the code myself
I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

Rust SDK
Sway compiler
Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
Someone else?

cursor · 2026-01-22T17:19:10Z

PR Summary

Medium Risk
Medium risk because it changes how FuelClient constructors interpret URLs (no longer auto-appending/overwriting /v1/graphql), which can break callers that relied on implicit normalization.

Overview
Client URL construction is refactored to remove implicit GraphQL endpoint normalization. normalize_url is made pub, FuelClient::new is deprecated (with guidance toward a forthcoming new_unchecked), and FuelClient::with_urls/new_with_rpc now mostly just parse URLs (only adding an http:// scheme when missing) instead of forcing the /v1/graphql path.

Call sites and tests are updated accordingly: e2e tests normalize endpoints explicitly before calling with_urls, the CLI and DoS test switch from new to with_urls, and the previous normalization-focused unit tests are removed/adjusted. A changelog entry is added for the new constructor work.

^{Written by Cursor Bugbot for commit 9f40c05. This will update automatically on new commits. Configure here.}

xgreenx · 2026-01-22T20:41:13Z

crates/client/src/client.rs

    }

+    #[cfg(feature = "rpc")]
+    pub async fn new_unchecked_with_rpc<G: AsRef<str>, R: AsRef<str>>(


new_with_rpc is not released, you can make this function automatically not affect the URL

I considered that but felt like it was inconsistent. I can change it though.

Let's remove this function, we have new_with_rpc which is enough

xgreenx · 2026-01-22T20:42:01Z

crates/client/src/client.rs

        Self::from_str(url.as_ref())
    }

+    pub fn new_unchecked(url: impl AsRef<str>) -> anyhow::Result<Self> {


Just deprecate the new method, we want people to start to use the new constructors with multiple URLs.

I meant we don't need new_unchecked anymore. we have method that accepts multiple endpoints

xgreenx · 2026-01-22T20:44:04Z

crates/client/src/client.rs

+        Ok(client)
+    }
+
    pub fn with_urls(urls: &[impl AsRef<str>]) -> anyhow::Result<Self> {


This function is only used by us, so we can also alter its behaviour and do not do normalization.

…client

crates/client/src/client.rs

xgreenx

I still we want to do at least instead of just Url::parse

    if !raw_url.starts_with("http") {
        raw_url = format!("http://{raw_url}");
    }

xgreenx · 2026-01-28T10:38:09Z

bin/e2e-test-client/tests/integration_tests.rs

+use tempfile::TempDir;
+// Used for writing assertions // Run programs


Suggested change

use tempfile::TempDir;

// Used for writing assertions // Run programs

use tempfile::TempDir;

bin/fuel-core-client/src/main.rs

xgreenx · 2026-01-28T10:39:39Z

crates/client/src/client.rs

        Self::from_str(url.as_ref())
    }

+    pub fn new_unchecked(url: impl AsRef<str>) -> anyhow::Result<Self> {


I meant we don't need new_unchecked anymore. we have method that accepts multiple endpoints

xgreenx · 2026-01-28T10:41:27Z

crates/client/src/client.rs

    }

+    #[cfg(feature = "rpc")]
+    pub async fn new_unchecked_with_rpc<G: AsRef<str>, R: AsRef<str>>(


Let's remove this function, we have new_with_rpc which is enough

…client

crates/client/src/client.rs

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

bin/fuel-core-client/src/main.rs

…client

MitchTurner added 2 commits January 21, 2026 14:41

Add unchecked constructors

ef3a020

Update CHANGELOG

acf1960

MitchTurner marked this pull request as ready for review January 22, 2026 17:19

MitchTurner requested review from a team, Dentosal and xgreenx as code owners January 22, 2026 17:19

This comment was marked as outdated.

Sign in to view

xgreenx reviewed Jan 22, 2026

View reviewed changes

depricate new, replace functions use of normalize

a9bb871

This comment was marked as outdated.

Sign in to view

Add normalization in test code

ff7bd11

MitchTurner requested a review from rymnc as a code owner January 22, 2026 22:24

Remove duplicate constructor

122f80d

This comment was marked as outdated.

Sign in to view

MitchTurner added 3 commits January 22, 2026 15:43

Merge branch 'master' into bugfix/add-unchecked-constructor-for-fuel-…

d2e1845

…client

Appease Clippy-sama, update constructor in test

4d3e17e

Remove import

a89fc08

This comment was marked as outdated.

Sign in to view

revert default url

21e1a87

cursor bot reviewed Jan 23, 2026

View reviewed changes

crates/client/src/client.rs Show resolved Hide resolved

MitchTurner self-assigned this Jan 23, 2026

xgreenx reviewed Jan 28, 2026

View reviewed changes

xgreenx and others added 2 commits January 28, 2026 12:41

Merge branch 'master' into bugfix/add-unchecked-constructor-for-fuel-…

087ea1e

…client

Merge branch 'master' into bugfix/add-unchecked-constructor-for-fuel-…

23d4e6e

…client

cursor bot reviewed Mar 13, 2026

View reviewed changes

crates/client/src/client.rs Outdated Show resolved Hide resolved

remove unneeded functions

cc2f8bd

cursor bot reviewed Mar 13, 2026

View reviewed changes

bin/fuel-core-client/src/main.rs Show resolved Hide resolved

MitchTurner added 2 commits April 1, 2026 08:54

Merge branch 'master' into bugfix/add-unchecked-constructor-for-fuel-…

5084c4a

…client

Address feedback

0d4db6d

fix constructor

9f40c05

		use tempfile::TempDir;
		// Used for writing assertions // Run programs

Conversation

MitchTurner commented Jan 21, 2026

Linked Issues/PRs

Description

Checklist

Before requesting review

After merging, notify other teams

Uh oh!

cursor bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

xgreenx left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cursor bot commented Jan 22, 2026 •

edited

Loading