chore: improve gas price service log context#3249
Open
ming1523 wants to merge 1 commit intoFuelLabs:masterfrom
Open
chore: improve gas price service log context#3249ming1523 wants to merge 1 commit intoFuelLabs:masterfrom
ming1523 wants to merge 1 commit intoFuelLabs:masterfrom
Conversation
PR SummaryLow Risk Overview Logs now include L2 block height/gas price (including explicit genesis/error cases), DA bundle id and L2 range/cost fields when buffering/applying DA costs, and explicit fields for persisted recorded DA height and the computed next gas price when updating the shared algorithm. Written by Cursor Bugbot for commit 7be5552. This will update automatically on new commits. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This is a small follow-up for
#1662. The gas price service already emits logs, but several of them are very generic (Received ...,Updating ...) or dump full debug payloads. This change keeps the same behavior while making the log stream more useful for operators and developers.Validation
crates/services/gas_price_service/src/v1/service.rsRef #1662
This change is operational/logging oriented. The
no changeloglabel seems appropriate if maintainers agree.