Skip to content

chore: fork stitches and improve it#227

Merged
pedronauck merged 6 commits into
masterfrom
feat/fork-stitches
Apr 11, 2023
Merged

chore: fork stitches and improve it#227
pedronauck merged 6 commits into
masterfrom
feat/fork-stitches

Conversation

@pedronauck

@pedronauck pedronauck commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

This pull request intends to copy stitches since it's unmaintained. Some modifications I made:

@pedronauck pedronauck self-assigned this Apr 5, 2023
@github-actions

github-actions Bot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Coverage report for ./design-system/react

St.
Category Percentage Covered / Total
🟢 Statements 93.59% 1664/1778
🟢 Branches 83.26% 363/436
🟢 Functions 83.9% 224/267
🟢 Lines 94.12% 1634/1736

Test suite run success

177 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 4e17f12

@luizstacio luizstacio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not release package stitches. We should probably bundle together with fuel-ui and fuel-react.

@LuizAsFight LuizAsFight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree stitches packages should be private (not released) and only accessible when developing fuel-ui locally

@LuizAsFight

Copy link
Copy Markdown
Contributor

card is looking too big (spacings and header text) is it expected and part of our design system? if not let's fix

image

@LuizAsFight

Copy link
Copy Markdown
Contributor

even simplest card is looking too big with too much spacing
image

@LuizAsFight

Copy link
Copy Markdown
Contributor

it's looking pretty decent @pedronauck congratz

did you test if it still works with linking locally to fuels-wallet repo ? would be nice to check

@pedronauck

pedronauck commented Apr 10, 2023

Copy link
Copy Markdown
Contributor Author

card is looking too big (spacings and header text) is it expected and part of our design system? if not let's fix

image

@LuizAsFight This PR isn't intended to have any changes in terms of design, it just has the fork of stitches. So, all these design specs are the same as the old version that is already published. But, of course, if this is not good we can change, but the ideal place to have this mentions should be here:

#228

@pedronauck pedronauck merged commit 8ae1cd7 into master Apr 11, 2023
@pedronauck pedronauck deleted the feat/fork-stitches branch April 11, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants