Vec implementation using slices #6933
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunilrj
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
xunilrj
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
CodSpeed Performance ReportMerging #6933 will not alter performanceComparing Summary
|
xunilrj
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
xunilrj
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
xunilrj
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
xunilrj
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
xunilrj
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
8 tasks
xunilrj
added a commit
that referenced
this pull request
Feb 28, 2025
## Description This PR is part of #5110. It fixes a problem that improves the usability of slices. When a method is returned from the "method resolution algorithm", if any generic is involved, it is returned as its generic form. So for example, if a method `len` is called on `Vec<u8>`, we return something like `fn len(self: Vec<T>)`. Later we monomorphize `T` into `u8`. To do that we run a "pattern match" to realize that we need to replace `T` with `u8`. In this case, the bug was that we were not considering that some primitive types have "implicit type parameters". This was found whilst creating more tests for #6933, because I was not able to call the `len` method defined for slices as: ```sway impl<T> &[T] { pub fn len(self) -> u64 { ... } } ``` ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
xunilrj
force-pushed
the
xunilrj/vec-using-slices
branch
from
dfd6ba0 to
ea54b06
Compare
xunilrj
force-pushed
the
xunilrj/vec-using-slices
branch
from
d541d91 to
b328dac
Compare
xunilrj
force-pushed
the
xunilrj/vec-using-slices
branch
from
d7445aa to
97a6d26
Compare
sdankel
reviewed
Mar 25, 2025
| @@ -1,3 +1,2 @@ | |||
| category = "run" | |||
| expected_result = { action = "return_data", value = "0000000003ffffc800000000000000040000000000000003" } | |||
| expected_result_new_encoding = { action = "return_data", value = "0000000000000003000000000000007c000000000000007c000000000000007c" } | |||
| expected_result_new_encoding = { action = "return_data", value = "0000000000000003 000000000000007c 000000000000007c 000000000000007c" } | |||
There was a problem hiding this comment.
I'm curious why expected_result is removed
There was a problem hiding this comment.
Now that "new_encoding" is enabled by default, it is only used if the old encoding is explicitly asked to be used.
xunilrj
force-pushed
the
xunilrj/vec-using-slices
branch
from
9e21b02 to
dba0a56
Compare
xunilrj
force-pushed
the
xunilrj/vec-using-slices
branch
from
447cfd4 to
e6dd95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a POC of using slices to implement
Vec<T>.Checklist
Breaking*orNew Featurelabels where relevant.