-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: implement forc add
and forc remove
to add/remove dependencies
#7143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@IGI-111 this is ready for review. I also noticed something, i was unable to trigger the lockfile update by just updating the members_manifest, it only worked when the forc.toml was already updated with new dependencies. |
CodSpeed Performance ReportMerging #7143 will not alter performanceComparing Summary
|
You may also want to integrate with the |
This looks nice but you need to add some tests and fix the CI errors before we can consider merging it. |
Alright will do that.
…On Mon, May 5, 2025, 10:47 AM IGI-111 ***@***.***> wrote:
*IGI-111* left a comment (FuelLabs/sway#7143)
<#7143 (comment)>
This looks nice but you need to add some tests and fix the CI errors
before we can consider merging it.
—
Reply to this email directly, view it on GitHub
<#7143 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANGCG5W7LKLXHHZEX2C7FW3244XRTAVCNFSM6AAAAAB4LUHOYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJQGQ3TCOBXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hey @JoE11-y thanks for the PR. Just letting you know I plan to look at this properly on Monday. |
I think we can handle the forc add/remove failure by adding the required field in clap for them.
Thank you @zees-dev and @kayagokalp ❤️ |
@zees-dev @kayagokalp resolved the comment removal issue and the forc add without dep failure. Thanks for helping reach this stage of the pr. And my apologies for being a little over zealous.🫡 |
Thanks for the contribution! Before we can merge this, we need @sdankel to sign the Fuel Labs Contributor License Agreement. |
Hey @JoE11-y, can you squash your changes by any chance? It seems like our ci step is blocked, as we have a commit in this branch (merge master commit) from a team member that recently left and the ci cla step is blocking because of that. If you can squash your commits and force push to this branch that will go away or you can override the author of each commit to this branch to be you. you should be able to somehting like: git reset --soft master
git add ...
git commit -m "feat: implement forc add and forc remove to add/remove dependencies"
git push origin feat/forc-edit-subcommands-impl -f |
Head branch was pushed to by a user without write access
6fccaf0
to
ee99a9b
Compare
Hi @kayagokalp all done. |
Description
Close #2369
Summary:
Implements functionality for
forc
to add remove dependencies through cli, similar to Cargo'sadd
andremove
commands.Work Done:
forc add
command to support adding both regular and contract dependencies from path, git, IPFS, or version.forc remove
to cleanly remove specified dependencies from the manifest.DepSection
enum for unified regular/contract dependency handling.toml_edit
to update the manifest file while preserving formatting.Checklist
Breaking*
orNew Feature
labels where relevant.