-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Keep track of interface surface status for entries in trait map. #7210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of interface surface status for entries in trait map. #7210
Conversation
CodSpeed Performance ReportMerging #7210 will not alter performanceComparing Summary
|
6389474
to
71781e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but ideally we should add a Rust test for this to make sure we don't reintroduce the behavior.
8f8d0db
to
ecc7a9d
Compare
I've added an assert now. |
149b5c4
to
dd7664d
Compare
Description
This adds bookkeeping information to the trait map so we can avoid emitting diagnostics for interface surface trait impls .
What happens is that during type checking, we first check the interface surface as a first pass, and only then do a second pass for the whole implementation, and this causes some issues with emitting diagnostics that should not be emitted.
Checklist
Breaking*
orNew Feature
labels where relevant.