Trait coherence fixes

[tritao]

Description

This bundles up a couple fixes related to the trait coherence feature.

Remove LSP workaround for skipping trait coherence checks.

This has been fixed and is not necessary anymore since the underlying issue was fixed in 12eee9e.

Use an hash set for calculating trait coherence unified trait types.

This prevents some duplicated entries from being considered when building the initial unified map for trait coherence checks.

Prevent duplicated trait coherence checks for conflicting types.

This fixes #7187 and fixes coherence checking when multiple versions of the same library exist in the same package.

Improve trait coherence orphan rule error with expressive diagnostics.

Checklist

• I have linked to any relevant issues.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • If my change requires substantial documentation changes, I have requested support from the DevRel team
• I have added tests that prove my fix is effective or that my feature works.
• I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
• I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
• I have requested a review from the relevant team or maintainers.

[codspeed-hq]

CodSpeed Performance Report

Merging #7211 will degrade performances by 14.29%

_{Comparing tritao:trait-map-coherence-fixes (8134221) with master (fe8a3ef)}

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	open_all_example_workspace_members	8.1 s	9.4 s	-14.29%