Change network-protocol classes to return netProtoErr_t instead of bool #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the network-protocol classes be explicit about error codes. Methods now return either NETPROTO_ERR_NONE or NETPROTO_ERR_UNSPECIFIED, which removes any confusion about the old true/false behavior and whether success or failure looked "backwards." The netProtoErr_t enum still matches the previous bool usage, so existing failure-check logic did not need any changes.
FozzTexx
force-pushed
the
feature/protocol-error
branch
from
c9b45ef to
96352cb
Compare
tschak909
approved these changes
Nov 10, 2025
Collaborator
tschak909
left a comment
tschak909
left a comment
There was a problem hiding this comment.
Yup makes sense. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the network-protocol classes be explicit about error codes. Methods now return either NETPROTO_ERR_NONE or NETPROTO_ERR_UNSPECIFIED, which removes any confusion about the old true/false behavior and whether success or failure looked "backwards." The netProtoErr_t enum still matches the previous bool usage, so existing failure-check logic did not need any changes.
Part of the process for removing
cmdFrame_tfrom the network-protocol classes.