[network-protocol] do not emit EOF on write. #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mode 0x0c (12) read/write was returning EOF when writing to the end of file.
Code was added to flag this, and to return a successful error if the write is successful.
Mode 0x0c (12) was also returning 0 bytes available for any file that had existing data. This was because the file was not stat() and filesize() had not been adjusted.
There is still a potential for reading and writing within the same file to cause a file size change, however, this will not come into play until seeking and telling (NOTE/POINT) are actually implemented in FS.