Skip to content

[ENHANCEMENT] Faster Game Over Mashing (and some cherries on top)#3826

Open
TechnikTil wants to merge 1 commit intoFunkinCrew:developfrom
TechnikTil:gameover-skipping
Open

[ENHANCEMENT] Faster Game Over Mashing (and some cherries on top)#3826
TechnikTil wants to merge 1 commit intoFunkinCrew:developfrom
TechnikTil:gameover-skipping

Conversation

@TechnikTil
Copy link
Contributor

@TechnikTil TechnikTil commented Nov 3, 2024 •
edited
Loading

About:

This PR adds the ability to skip the confirm sound in GameOverSubState, making it even faster to restart a song. Also, this PR prevents death sound effects from colliding into each other, and organizes a little bit.

Associated Assets PR:

FunkinCrew/funkin.assets#287

Video:

yt video cuz its over 10MB

Important Info

This PR has changes for admob ad displaying, which I cannot test.

@github-actions github-actions bot added size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed size: large A large pull request with more than 100 changes. labels Nov 3, 2024
@Hundrec
Copy link
Member

Hundrec commented Nov 3, 2024

Ooh, this would address a lot of existing issues!
Can we see a video?

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Nov 3, 2024 •
edited
Loading

Ooh, this would address a lot of existing issues! Can we see a video?

yt video
(i could make one thats less of a joke if you need)

@Hundrec
Copy link
Member

Hundrec commented Nov 3, 2024

Oh whoops, missed the link
This video is actually hilarious and gets the point across, love it!

@CrusherNotDrip
Copy link
Contributor

CrusherNotDrip commented Nov 3, 2024

yt video cuz its over 10MB

https://8mb.video/ unless u dont want it to look a bit poo poo

@CrusherNotDrip
Copy link
Contributor

CrusherNotDrip commented Nov 3, 2024

also i found this pr because of u posting this on youtube 😭

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Nov 3, 2024

also i found this pr because of u posting this on youtube 😭

lmao

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Nov 5, 2024

ok, i found a bug

if you spam enough in week 6, the pixel fade shader says fuck you and breaks

gonna go fix that rq

@CrusherNotDrip
Copy link
Contributor

CrusherNotDrip commented Nov 6, 2024

ok, i found a bug
if you spam enough in week 6, the pixel fade shader says fuck you and breaks
gonna go fix that rq

gonna make that a different pr hahahahahpahljifjnbdasjhklfg adshjikubgvads jghkfgasd hgvfkdsghj kmf djghksafkhj gdsf

BOOOO L PR 0/10 I HATE PEOPLE NAMED TECHNIKTIL BOOOO

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Dec 14, 2024

there we go (sorry)

@github-actions github-actions bot added the size: large A large pull request with more than 100 changes. label Dec 14, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jan 17, 2025
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
Hundrec
Hundrec requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finally gotten around to testing this and quickly encountered a bug
I'm not sure how often this would happen, but I couldn't make it happen on command.

Just wanted to let you know!

gameover.mash.mp4

@charlesisfeline
Copy link
Contributor

charlesisfeline commented Feb 20, 2025

I've finally gotten around to testing this and quickly encountered a bug I'm not sure how often this would happen, but I couldn't make it happen on command.

Just wanted to let you know!

gameover.mash.mp4

stopping the inst works half of the time. apparently...

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Feb 20, 2025

I've finally gotten around to testing this and quickly encountered a bug

I'm not sure how often this would happen, but I couldn't make it happen on command.

Just wanted to let you know!

gameover.mash.mp4

oop
ill go push a fix in a few, currently just got out of school

@JackXson-Real
Copy link
Contributor

JackXson-Real commented Feb 20, 2025

I've finally gotten around to testing this and quickly encountered a bug
I'm not sure how often this would happen, but I couldn't make it happen on command.
Just wanted to let you know!

gameover.mash.mp4

oop ill go push a fix in a few, currently just got out of school

I got the issue too. It seems to happen when you restart on the exact same frame the song starts, so it's basically a frame perfect input you have to do. Pretty fun to mess around with tho

@JackXson-Real
Copy link
Contributor

JackXson-Real commented Feb 20, 2025

Darnell schizo moment

Base.Profile.2025.02.20.-.17.49.31.01.mp4

@JackXson-Real
Copy link
Contributor

JackXson-Real commented Feb 20, 2025

No way I just got the rare death screen while testing lmao
screenshot-2025-02-20-17-53-25

@Hundrec
Copy link
Member

Hundrec commented Feb 20, 2025

I didn't even know the rare death screen was implemented, crazy!

AbnormalPoof
AbnormalPoof approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@EliteMasterEric
Copy link
Member

EliteMasterEric commented Feb 22, 2025

I should ask what the team's opinions on this are.

Have all the issues with it been resolved? Will mark as needs revision until they are

@EliteMasterEric EliteMasterEric added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Feb 22, 2025
@JackXson-Real
Copy link
Contributor

JackXson-Real commented Feb 22, 2025

I should ask what the team's opinions on this are.

Have all the issues with it been resolved? Will mark as needs revision until they are

I think they still have yet to fix the issue reported by Hundrec.

@Hundrec Hundrec removed the request for review from charlesisfeline May 14, 2025 10:33
@EliteMasterEric EliteMasterEric added size: large A large pull request with more than 100 changes. and removed size: large A large pull request with more than 100 changes. labels May 14, 2025
@TechnikTil TechnikTil force-pushed the gameover-skipping branch 2 times, most recently from 5a6b889 to 20ae417 Compare October 14, 2025 19:05
@TechnikTil TechnikTil mentioned this pull request Oct 14, 2025
Open
JackXson-Real
JackXson-Real approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@JackXson-Real JackXson-Real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@Hundrec Hundrec added the topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. label Oct 15, 2025
@Hundrec Hundrec removed the request for review from charlesisfeline January 16, 2026 06:39
@Hundrec Hundrec force-pushed the develop branch 2 times, most recently from 3829dcb to 5805c31 Compare February 1, 2026 03:24
@github-actions github-actions bot added size: huge A huge pull request with more than 500 changes. and removed size: large A large pull request with more than 100 changes. labels Feb 2, 2026
@TechnikTil
Copy link
Contributor Author

TechnikTil commented Feb 2, 2026

this is the closest thing im gonna get to a child

so close that i forgot it's birthday :(

@TechnikTil
Game Over Mashing (with sprinkles and a cherry)
245aa34 
Signed-off-by: TechnikTil <techniktil@tilnotdrip.org>
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. and removed size: huge A huge pull request with more than 500 changes. labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbnormalPoof AbnormalPoof Awaiting requested review from AbnormalPoof

@Hundrec Hundrec Awaiting requested review from Hundrec

3 more reviewers

@JackXson-Real JackXson-Real JackXson-Real approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@CrusherNotDrip CrusherNotDrip CrusherNotDrip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. type: enhancement Involves an enhancement or new feature.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@TechnikTil @Hundrec @CrusherNotDrip @charlesisfeline @JackXson-Real @EliteMasterEric @AbnormalPoof

Comments