[BUGFIX] Don't dispatch conductor events if substate is active#6886
Open
KoloInDaCrib wants to merge 1 commit intoFunkinCrew:developfrom
Open
[BUGFIX] Don't dispatch conductor events if substate is active#6886KoloInDaCrib wants to merge 1 commit intoFunkinCrew:developfrom
KoloInDaCrib wants to merge 1 commit intoFunkinCrew:developfrom
Conversation
github-actions
bot
added
status: pending triage
Hundrec
added
type: minor bug
Hundrec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Nope.
Description
When in a SubState, for example after dying in PlayState, the callbacks beatHit and stepHit of the parent state are still attached to the same Conductor instance and get dispatched. This leads to a weird effect where if you die in the week 2 stage, lightning can still strike.
This PR fixes it by checking if the parent state has a substate attached to it and if it can update with it attached before dispatching the conductor callbacks.
Screenshots/Videos