Skip to content

[BUGFIX] Make Countdown react to offsets#7608

Open
zxcksharks wants to merge 2 commits into
FunkinCrew:developfrom
zxcksharks:countdown-offset-sync
Open

[BUGFIX] Make Countdown react to offsets#7608
zxcksharks wants to merge 2 commits into
FunkinCrew:developfrom
zxcksharks:countdown-offset-sync

Conversation

@zxcksharks
Copy link
Copy Markdown

Previously, the countdown didn't react to the global offset at all.
Now it does! Amazing.

Linked Issues

Still none! But an old pull request #4496

Description

The countdown would always be desynced if you had great audio latency regardless of your offsets.
Here, the game will now check if you have it set to something other than 0, and adjust accordingly.
Which one plays first depends on if your offset is positive or negative (obviously)

Screenshots/Videos

Before:

Video_2026-05-22_00-27-35.mp4

After:

Video_2026-05-22_00-26-48.mp4

@github-actions github-actions Bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels May 21, 2026
@zxcksharks

This comment was marked as resolved.

@NotHyper-474 NotHyper-474 added the type: minor bug Involves a minor bug or issue. label May 21, 2026
@Starexify
Copy link
Copy Markdown
Contributor

Offtopic, but while I was building the newest branch of develop, it (might have) broken my pipewire installation :( Not sure if I should make an issue request for this because I'm not sure if this is a Funkin' issue, upstream issue, or an issue on my Linux installation...

I havent gotten that issue. Not sure how compiling funkin could even "break" the sound library

@zxcksharks
Copy link
Copy Markdown
Author

zxcksharks commented May 22, 2026

I havent gotten that issue. Not sure how compiling funkin could even "break" the sound library

Seems like my pipewire was broken in general, and the develop build was the only app that forcibly used it.
I've been relying on pulseaudio since, and have removed most pipewire-related stuff (and it works!)

EDIT: Fixed my pipewire installation entirely! Funkin' wasn't the problem remotely :D

@Hundrec Hundrec changed the title [ENHANCEMENT/FIX] Countdown reacts to offsets [BUGFIX] Make Countdown react to offsets May 22, 2026
Turns out the array doesn't help if you're still referencing the same timer elsewhere...
@zxcksharks zxcksharks force-pushed the countdown-offset-sync branch from e4b231c to cb48831 Compare May 26, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

3 participants