[BUGFIX] Fix non scripted variation songs using default variation script#7613
Open
ahmed7p wants to merge 1 commit into
Open
[BUGFIX] Fix non scripted variation songs using default variation script#7613ahmed7p wants to merge 1 commit into
ahmed7p wants to merge 1 commit into
Conversation
github-actions
Bot
added
status: pending triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where custom variation songs were running the default variation script if there is no script for them
Changelog
unscriptedSongVariationsmap to register and track non-scripted song variations.loadEntries()to safely iterate through entry variations and populate the new unscripted variations map.fetchEntry()to prioritize scripted variations first, then unscripted variations, preventing them from falling back to the default variation script.Screenshots/Videos
Before
2026-05-22.05-32-32.mp4
After
2026-05-22.05-30-54.mp4