[BUGFIX] Fall back to default vocal offset when alt instrumental has none#7630
Open
VICK-sys wants to merge 1 commit into
Open
[BUGFIX] Fall back to default vocal offset when alt instrumental has none#7630VICK-sys wants to merge 1 commit into
VICK-sys wants to merge 1 commit into
Conversation
github-actions
Bot
added
status: pending triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #7616
Description
SongOffsets.getVocalOffset(charId, instrumental)returned0.0when the requested alt instrumental had noaltVocalsentry, silently dropping the defaultvocals[charId]offset even though vocal files are shared across instrumentals. Fall back to the default offset unless the alt explicitly overrides it. Also treatinstrumental == ''the same asnull—Song.buildVocalspasses''for the default case, which previously fell into the alt branch and dropped the default offset there too. Now matchesgetInstrumentalOffset's handling.Screenshots/Videos
See the original reporter's video on #7616