[ENHANCEMENT] Note Quantization

[VICK-sys]

Linked Issues

Addresses #2933

Description

Adds a "Note Quantization" preference that colors notes by their quantization (4th, 8th, 16th, etc.). Applies to gameplay (including chart playtesting) and the chart editor grid, controlled by a single toggle in Options → Preferences. Default off.

Screenshots/Videos

Demo2.mp4

[EliteMasterEric]

This feature has been on my mind for a while so cool to see a contribution addressing it.

Aside from the issue that the colors are pretty ugly (this would have to be addressed in its own PR that provides better customization of note colors), you're creating a new shader instance for each note, which creates lots of objects that get quickly discarded, and additionally disables an important optimization to note rendering. Having a single shared shader object for every quarter note will draw them all at once, like in the video in the linked PR.

[Starexify]

I think that firstly, the Note Customization option should be added, and then this feature :p

[VICK-sys]

This feature has been on my mind for a while so cool to see a contribution addressing it.

Aside from the issue that the colors are pretty ugly (this would have to be addressed in its own PR that provides better customization of note colors), you're creating a new shader instance for each note, which creates lots of objects that get quickly discarded, and additionally disables an important optimization to note rendering. Having a single shared shader object for every quarter note will draw them all at once, like in the video in the linked PR.

Anything in particular you would want from the customization of note colors as an option?