Skip to content

make discord-rpc use characters icon data#7643

Merged
Hundrec merged 1 commit into
FunkinCrew:dummy/develop-v0.8.5from
7oltan:make-discordrpc-use-characters-icon
Jun 8, 2026
Merged

make discord-rpc use characters icon data#7643
Hundrec merged 1 commit into
FunkinCrew:dummy/develop-v0.8.5from
7oltan:make-discordrpc-use-characters-icon

Conversation

@7oltan
Copy link
Copy Markdown
Contributor

@7oltan 7oltan commented May 27, 2026

discord rpc uses the characters id rather then its icon id in its character json, this is an easy fix and it removes alot of the duplicate
icons in the funkin.art/discord folder and i think will help modders

i have not playtested this pr (ik make fun of me but i cant build develop rn) so if someone can try if it works before that would be
helpful

these are icons that do not exist in the funkin.art/discord folder so they will not show up:
all of lesserafims icon
pico pixel
week5 parents
tankmen (bloody)

@github-actions github-actions Bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: tiny A tiny pull request with 4 or fewer changes. labels May 27, 2026
@NotHyper-474 NotHyper-474 added the type: minor bug Involves a minor bug or issue. label May 27, 2026
@Hundrec Hundrec requested a review from AbnormalPoof May 30, 2026 00:42
Copy link
Copy Markdown
Member

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Jun 8, 2026
@Hundrec Hundrec added this to the 0.8.6 milestone Jun 8, 2026
@Hundrec Hundrec changed the base branch from develop to dummy/develop-v0.8.5 June 8, 2026 08:28
@Hundrec Hundrec merged commit ab31ed5 into FunkinCrew:dummy/develop-v0.8.5 Jun 8, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

4 participants