[ENHANCEMENT] Add a PlayState check to initHealthIcon() and playAnimation()#7646
Open
zxcksharks wants to merge 1 commit into
Open
[ENHANCEMENT] Add a PlayState check to initHealthIcon() and playAnimation()#7646zxcksharks wants to merge 1 commit into
zxcksharks wants to merge 1 commit into
Conversation
This allows stages to be fully utilized outside of PlayState.
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
None I could find
Description
Before this PR, stages were unable to be utilized to their full potential outside PlayState (
addCharacter()would callinitHealthIcon()which promptly throws an error outside of PlayState)By adding checks here, we allow both stages and characters to function independently from PlayState.
Screenshots/Videos
(Shown:
bfinmainStagewithcharacterType = BFin a custom state)