[FEATURE] Move songScore to a new class

[zxcksharks]

Note

Breaking change - all scripts using songScore must now reference SongScore.instance.getScore().

Linked Issues

N/A

Description

In PlayState.hx, songScore used to have a TODO comment saying "Move this to a class."
Not sure if that's still needed, but I did it anyway! This allows us to add further logic into score logic when needed.

This used to be part of a bigger PR I was working on, regarding held note scoring consistency.
However, I'm holding off (giving up?) on that for now until some other PRs are pulled (namely #6914) and until my psyche recovers (my contributions to FNF last about as long as I am motivated, and I can't promise anything 😭 )

For the details on the incomplete held note scoring PR, if anyone wants to tackle it themselves if I die or just out of curiosity (it's worked on in my accurate-sustains branch):

• Add a field called pendingPoints and function getWithPending() to the new SongScore class
• Currently held notes will apply their score there as an integer, instead of at the real points variable
• Hold notes will also hold a new appliedScore field, tracking how much score they've applied to pendingScore so far
• Move player hold note logic to processInputQueue (maybe into a function called goodHoldNoteHit())
• When held notes are released, calculate the diff like you would in goodNoteHit(), remove the appliedScore from the pendingScore, and apply the real score to points.
  This would be a massive change in input handling, which is why I didn't do it 😅

Screenshots/Videos

N/A

[zxcksharks]

i targeted the wrong branch whoops

[NotHyper-474]

Does this have any difference over #5114? (Although it doesn't seem like that one will be updated anytime soon)

[zxcksharks]

Does this have any difference over #5114? (Although it doesn't seem like that one will be updated anytime soon)

Not much, but it does use a singleton pattern instead of a static class
(Though I don't know if I'm doing singletons right... I'm just using the interface 😅)