[ENHANCEMENT] Make Level.getDifficulties() actually return the final list#7648
Open
TechnikTil wants to merge 1 commit into
Open
[ENHANCEMENT] Make Level.getDifficulties() actually return the final list#7648TechnikTil wants to merge 1 commit into
Level.getDifficulties() actually return the final list#7648TechnikTil wants to merge 1 commit into
Conversation
… shown. Signed-off-by: TechnikTil <techniktil@tilnotdrip.org>
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR rewrites how Story Mode gets difficulties by making
Level.getDifficultiesreturn exactly what is shown to the user, which is usually the difficulties of the default variation.By doing this, it removes the need of doing hard coded filtering in
StoryMenuState.changeDifficultyentirely.There is visually no difference with this PR, but it lets mods add custom difficulties to Story Mode by adding them to their default variation.