[Enhancement] Add Funkin' version as compilation flag#7659
Open
zxcksharks wants to merge 1 commit into
Open
Conversation
for polymod!!!!
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
This would not close #7658, but is related.
Description
In the far future where backwards compatibility may become an important focus in Funkin', allowing modders to query the current version in pre-processing would allow modders to only create one set of scripts that adapt to multiple versions at once.
Even now, when developing PRs, if you're implementing breaking changes but have scripts that rely on said breaking changes, if those scripts constantly break while switching between release and compiled versions then this may be an easy fix to use.
This relates to my enhancement issue at #7658, but it does not implement mod-specific API version rules. (Seems more like a Polymod thing, and I'm not well-versed in that codebase)
Screenshots/Videos
N/A