Skip to content

[BUGFIX] Correct scale multiplier in scaleElement function - #7778

Open
DeRealTurbo wants to merge 2 commits into
FunkinCrew:developfrom
DeRealTurbo:patch-1
Open

[BUGFIX] Correct scale multiplier in scaleElement function#7778
DeRealTurbo wants to merge 2 commits into
FunkinCrew:developfrom
DeRealTurbo:patch-1

Conversation

@DeRealTurbo

Copy link
Copy Markdown

The documentation describes scale as a multiplier, even though the implementation adds it to the current scale.
If this behavior is intentional, then the documentation should be updated

MRK2009 and others added 2 commits June 21, 2026 21:22
The documentation describes scale as a multiplier, even though the implementation adds it to the current scale.

If this behavior is intentional, then the documentation should be updated
@github-actions github-actions Bot added pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: pending triage Awaiting review. labels Jul 20, 2026
@NotHyper-474 NotHyper-474 added the type: minor bug Involves a minor bug or issue. label Jul 20, 2026
@Hundrec

Hundrec commented Jul 21, 2026

Copy link
Copy Markdown
Member

This sounds right, but would it be a breaking change for anything using this right now?

@DeRealTurbo

DeRealTurbo commented Jul 21, 2026

Copy link
Copy Markdown
Author

This sounds right, but would it be a breaking change for anything using this right now?

Kind of, the scale is now using multiplication instead of addition.
So it would result in elements which this function is used on having a different scale.

Base-game itself does not use this function anywhere as of now.
And I can not recall ever seeing a mod taking usage of it either.
So it would be wise to patch this before it is used.

@KT-Gameplay

Copy link
Copy Markdown

When ur about to make a change, make a branch with its source as develop branch and then put ur changes in that branch.
While making pull request, make it to the develop branch rather than the main branch.

@DeRealTurbo

Copy link
Copy Markdown
Author

When ur about to make a change, make a branch with its source as develop branch and then put ur changes in that branch. While making pull request, make it to the develop branch rather than the main branch.

So sorry, I will do that!
Thank you very much

@KT-Gameplay

KT-Gameplay commented Jul 21, 2026

Copy link
Copy Markdown

u didnt have to close it bruh
u just had to force push that branch to it and change the target branch from main to develop in the title editing thing

DeRealTurbo added a commit to DeRealTurbo/Funkin that referenced this pull request Jul 21, 2026
(Move pull request from Main to Develop, FunkinCrew#7778,  so sorry)

The documentation describes scale as a multiplier, even though the implementation adds it to the current scale.
If this behavior is intentional, then the documentation should be updated
@DeRealTurbo

Copy link
Copy Markdown
Author

u didnt have to close it bruh u just had to force push that branch to it and change the target branch from main to develop in the title editing thing

Oh, I did not know that this was possible.
My apologies

@Hundrec Hundrec reopened this Jul 21, 2026
@Hundrec
Hundrec changed the base branch from main to develop July 21, 2026 13:38
@github-actions github-actions Bot added pr: github PR modifies GitHub metadata files. size: medium A medium pull request with 100 or fewer changes. and removed size: tiny A tiny pull request with 4 or fewer changes. labels Jul 21, 2026
@Hundrec Hundrec changed the title Correct scale multiplier in scaleElement function [BUGFIX] Correct scale multiplier in scaleElement function Jul 21, 2026
@Hundrec Hundrec removed the pr: github PR modifies GitHub metadata files. label Jul 21, 2026
@DeRealTurbo

Copy link
Copy Markdown
Author

Thank you very much Hundrec, Once again so sorry.
I should have known this beforehand 🙈

@Hundrec Hundrec added size: tiny A tiny pull request with 4 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Jul 21, 2026
@KT-Gameplay

Copy link
Copy Markdown

actually, idk how u do a force push but i think it requires git maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

6 participants