Skip to content

[CRASHFIX] Fix crash scrolling waveforms in the Offsets Toolbox when exiting with F4 - #8054

Merged
Hundrec merged 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:fix-crash-offset
Aug 30, 2026
Merged

[CRASHFIX] Fix crash scrolling waveforms in the Offsets Toolbox when exiting with F4#8054
Hundrec merged 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:fix-crash-offset

Conversation

@kiryvajiravuth

@kiryvajiravuth kiryvajiravuth commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Linked Issues

closes #6732

Description

Prevent crash when pressing F4 while scrolling in OffsetToolbox in ChartEditor

Screenshots/Videos

Before :

before.mp4

After :

after.mp4

@github-actions github-actions Bot added size: tiny A tiny pull request with 4 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: tiny A tiny pull request with 4 or fewer changes. labels Aug 30, 2026
@kiryvajiravuth kiryvajiravuth changed the title fix offsets waveform crash on state switch [BUGFIX] Fix offsets waveform crash on state switch Aug 30, 2026
@kiryvajiravuth kiryvajiravuth changed the title [BUGFIX] Fix offsets waveform crash on state switch [BUGFIX] Fix crash scrolling waveforms in the Offsets Toolbox when exiting with F4 Aug 30, 2026
@kiryvajiravuth kiryvajiravuth changed the title [BUGFIX] Fix crash scrolling waveforms in the Offsets Toolbox when exiting with F4 [CRASHFIX] Fix crash scrolling waveforms in the Offsets Toolbox when exiting with F4 Aug 30, 2026
@Hundrec
Hundrec force-pushed the preview/public-playtest branch from ae0e3ff to b190bf7 Compare August 30, 2026 11:12
@kiryvajiravuth

kiryvajiravuth commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

oh no merge conflicts :nails:

@github-actions github-actions Bot added the size: tiny A tiny pull request with 4 or fewer changes. label Aug 30, 2026
@Hundrec Hundrec added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression topic: chart editor Related to the operation of the Chart Editor. labels Aug 30, 2026
@Hundrec Hundrec linked an issue Aug 30, 2026 that may be closed by this pull request
Crash Report: Chart Editor | Scrolling the waveforms in the offsets window crashes when pressing F4 #6732
Open
4 tasks
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Aug 30, 2026
Hundrec
Hundrec approved these changes Aug 30, 2026
View reviewed changes

@Hundrec Hundrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the crash, good!

@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Aug 30, 2026
@Hundrec Hundrec added this to the 0.9.0 - Week 8 milestone Aug 30, 2026
@Hundrec
Hundrec merged commit ad9a5a5 into FunkinCrew:preview/public-playtest Aug 30, 2026
8 checks passed
@kiryvajiravuth
kiryvajiravuth deleted the fix-crash-offset branch August 30, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hundrec Hundrec Hundrec approved these changes

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Milestone

0.9.0 - Week 8

Development

Successfully merging this pull request may close these issues.

Crash Report: Chart Editor | Scrolling the waveforms in the offsets window crashes when pressing F4

2 participants

@kiryvajiravuth @Hundrec