Pulling in latest httpx-aiohttp to resolve break with vcrpy
#1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
jabra,
maykcaldas,
mskarlin,
sidnarayanan and
whitead
dosubot
bot
added
the
size:S
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the httpx-aiohttp package from version 0.1.9 to 0.1.12 to resolve compatibility issues with vcrpy. The update includes a new patch in the test configuration to handle raw headers in aiohttp responses.
- Updates
httpx-aiohttpdependency to version 0.1.12 - Adds version constraint
>=0.1.11for the dev extra to ensure the raw headers fix is present - Implements a workaround patch for vcrpy's aiohttp stub to properly set
_raw_headerson mock responses
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Adds version constraint >=0.1.11 for httpx-aiohttp in dev dependencies with comment explaining the raw headers fix |
| uv.lock | Updates httpx-aiohttp from 0.1.9 to 0.1.12, adds the package to dev optional dependencies, and updates metadata |
| tests/conftest.py | Adds import for vcr.stubs.aiohttp_stubs and implements a patch function that ensures _raw_headers is properly set on mock responses when _headers exists |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working around kevin1024/vcrpy#962