Add configurable week start day preference#1364
Open
daviddavis wants to merge 1 commit intoFuzzyGrim:devfrom
Open
Add configurable week start day preference#1364daviddavis wants to merge 1 commit intoFuzzyGrim:devfrom
daviddavis wants to merge 1 commit intoFuzzyGrim:devfrom
Conversation
daviddavis
commented
Apr 19, 2026
daviddavis
commented
- Add WeekStartDayChoices model and week_start_day field to User
- Add week start day dropdown to preferences page with new week SVG icon
- Update statistics activity grid to respect week start day setting
- Update events calendar to respect week start day setting
- Dynamically render weekday labels in both statistics and calendar views
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a user preference for the 'Week Start Day' (Monday or Sunday), affecting both the calendar view and activity statistics. Changes include updates to the User model, a new migration, and logic adjustments in statistics.py and events/views.py to align date calculations and UI labels with the chosen start day. Feedback suggests using the calendar module's day_abbr for dynamic weekday labels, adding a database-level CheckConstraint for the new field, and validating user input in the preferences view.
daviddavis
force-pushed
the
add-week-start-pref
branch
3 times, most recently
from
8cce645 to
75f469d
Compare
- Add WeekStartDayChoices model and week_start_day field to User - Add week start day dropdown to preferences page with new week SVG icon - Update statistics activity grid to respect week start day setting - Update events calendar to respect week start day setting - Dynamically render weekday labels in both statistics and calendar views Co-authored-by: GitHub Copilot <noreply@github.com>
daviddavis
force-pushed
the
add-week-start-pref
branch
from
75f469d to
4bde0c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.