implement a rest-endpoint for medialist#772
Closed
chinatsu wants to merge 3 commits intoFuzzyGrim:devfrom
Closed
Conversation
Owner
|
Isn't the response very slow because you are fetching metadata for each media? |
Author
|
i haven't tested this branch on any large set of data, so it hasn't been particularly slow for me. i'll give that a shot though, and see how slow it is! |
Owner
|
I will close this PR in favor of #924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i was a little inspired by #488 and decided to spend a little while to make a very rudimentary endpoint for medialist.
the api key used for other integrations is what authorizes the call, though i stuck it into a query parameter rather than part of the url like the other integrations, because i didn't really want something looking like
/api/medialist/tv/apikeyherei ran into some issues trying to set up every data provider (especially mal), so i haven't been able to test it properly-properly.
during my own testing, i tried using these endpoints in my *arr-stuff, just to see if i could use the endpoint as an import list, and import a tv series and a movie. this is my main motivation to be working on this (hence the camelCase keys.. lol). i believe these integrations ignore unfamiliar keys, so we could definitely expand on the return types, and make it more unified. e.g. this for every media type?
{ "id": media_id, "tvdbId": None if not tvdb_id else tvdb_id, "name": name, # etc. }i'll look into this a little bit, though i'm happy to receive feedback, and i'm also fine having this closed if it's super stupid to add to your codebase!