Skip to content

docs(dispatch): correct dispatch-composer-evidence.md and headless-dispatch design.md - #78

Merged
G-Hensley merged 1 commit into
mainfrom
docs/dispatch-evidence-corrections
Sep 11, 2026
Merged

docs(dispatch): correct dispatch-composer-evidence.md and headless-dispatch design.md#78
G-Hensley merged 1 commit into
mainfrom
docs/dispatch-evidence-corrections

Conversation

@G-Hensley

@G-Hensley G-Hensley commented Sep 10, 2026

Copy link
Copy Markdown
Owner

What changed and why

Five small corrections to two docs landed in #77 (dispatch-composer-evidence.md, headless-dispatch/design.md), no expansion, no product source touched:

  • Evidence doc's own stale BACKLOG.md line-209 citation replaced with a heading-anchor link to the "Dispatch loses whole 1 KiB chunks..." entry (currently line 243), so it survives future line drift. design.md's own "209" citation is left as-is: it's pinned to historical commit 2907adf by the file's existing convention and was accurate for that commit.
  • "#![cfg(target_os = "linux")] and will not compile elsewhere" corrected to "compiles to an empty crate on any other platform rather than failing to compile."
  • Invocation section corrected: no model request is made because the fixture never submits the prompt, not because of the -s read-only -a never flags.
  • Shared::prompt_limit corrected to SessionManager::prompt_limit in design.md (verified against impl SessionManager at lib.rs:591).
  • Removed the one em dash in design.md.

Cross-model review

See CONTRIBUTING.md for the full process. Summary here:

  • Implementer: Claude Code, sess-3
  • Reviewer: root, Codex/gpt6Astra, different from the implementer
  • Review result: approved (precommit diff review, before this commit was made)

Verification

  • cargo test run locally: not applicable: docs-only change, no source touched
  • pnpm build run locally: not applicable: docs-only change, no source touched

Security impact

  • None

Scope

  • This diff contains only the intended change; no unrelated files or another session's untracked or uncommitted work are included

Docs-only, 2 files changed (13 insertions, 7 deletions). Diff was reviewed and approved by root before this commit was made, per the recovery task's own precommit-review requirement.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NUFXMx3cG7t89s51BtU8VW

…spatch design.md

Five small corrections to the docs landed in #77 (merged as 2fcd42c),
no expansion, no product source changes:

- Replace the evidence doc's own stale BACKLOG.md line-209 citation with
  a heading-anchor link to "Dispatch loses whole 1 KiB chunks from the
  head of a long prompt" (currently line 243), so it survives future
  line drift instead of going stale again. design.md's own "209"
  citation is left untouched: it is pinned to historical commit
  2907adf by the file's existing convention and was accurate for that
  commit.
- Correct "#![cfg(target_os = "linux")] and will not compile elsewhere"
  to "compiles to an empty crate on any other platform rather than
  failing to compile": the cfg attribute empties the module, it does
  not block compilation.
- Correct the Invocation section: no model request is made because the
  fixture never submits the prompt, not because of the
  -s read-only -a never flags (those are additional insurance, not the
  actual reason).
- Correct Shared::prompt_limit to SessionManager::prompt_limit in
  design.md (impl SessionManager at lib.rs:591 owns prompt_limit at
  lib.rs:631; there is no Shared type at that location).
- Remove the one em dash in design.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NUFXMx3cG7t89s51BtU8VW
Copilot AI lite review requested due to automatic review settings September 10, 2026 23:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@daedalus-orion daedalus-orion Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated security review

No findings in the six categories this review covers.

Reviewed a1396ed25b30. This review does not approve or block; a human decides.

@daedalus-orion daedalus-orion Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated documentation review

No findings in the four categories this review covers.

Reviewed a1396ed25b30. This review does not approve or block; a human decides.

@G-Hensley
G-Hensley merged commit 3acb18c into main Sep 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants