-
Notifications
You must be signed in to change notification settings - Fork 1
Bump fantomas and fsharp-analyzers #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps fantomas from 7.0.1 to 7.0.3 Bumps fsharp-analyzers from 0.30.0 to 0.32.0 --- updated-dependencies: - dependency-name: fantomas dependency-version: 7.0.3 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: fsharp-analyzers dependency-version: 0.32.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
(If you were closing/reopening to rerun the pipelines, the problem is that the analysers also need to be bumped.) |
nojaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes me wonder if the frequency of these updates is slightly too high. Updating these analysers and Fantomas every quarter might be sufficient as well.
|
Agreed, I suspect we can turn Dependabot down here. I suppose the ultimate source of the backward-incompatibility is that the SDK uses types from FSharp.Compiler.Services which are liable to change as upgrades happen, and there's no easy way to ship multiple versions of FCS in the analyser SDK at the same time. It doesn't seem to me that those types should need to change very often, though; having some kind of highly-backward-compatible shim between FCS and the analyser SDK would be annoying but I predict it would reduce this churn a lot. |
Yup, very much! However, since analysers never quite gained traction in the community, determining the surface area of a stable, decoupled API from FCS is challenging. I'm also curious if a group entry for the tool and NuGet package would be effective. You could do something like this: groups:
analyzers:
patterns:
- "fsharp-analyzers"
- "G-Research.FSharp.Analyzers"I'm unsure if this approach would work, given that one is a tool and the other is a regular NuGet package. |
Updated fantomas from 7.0.1 to 7.0.3.
Release notes
Sourced from fantomas's releases.
7.0.3
7.0.3
Fixed
Special thanks to @Numpsy and @nojaf!
https://www.nuget.org/packages/fantomas/7.0.3
7.0.2
7.0.2
Changed
Fixed
Special thanks to @alex-de-oliveira and @dawedawe!
https://www.nuget.org/packages/fantomas/7.0.2
Commits viewable in compare view.
Updated fsharp-analyzers from 0.30.0 to 0.32.0.
Release notes
Sourced from fsharp-analyzers's releases.
0.32.0
Added
Changed
0.31.0
Changed
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)