feat(auth): decouple authorization and admin layout #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jescalada
changed the title
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage ? 61.88%
=======================================
Files ? 49
Lines ? 1805
Branches ? 0
=======================================
Hits ? 1117
Misses ? 688
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…ples-manager chore(deps): update dependency @finos/git-proxy to ^1.9.3 - git-proxy-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…es/git-proxy-cli/package.json
fix(deps): update dependency axios to ^1.8.4 - git-proxy-cli - packages/git-proxy-cli/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR for #9 builds on top of #7 and #10, making route access more intuitive. All
/adminroutes have been replaced with/dashboard, and relevant files have been renamed. Actual admin-only routes, such as the list of users, are displayed with the/admin/prefix. For example:/dashboard/admin/user.Merging the first two PRs should make this one more manageable! 😃
Unit tests execute the same way as before, and E2E tests have been expanded and amended to work with the new setup.
I also added some quality-of-life features, such as fixing the redirect on login, which had a confusing flow (that was erroring out when logging from the admin/admin account).
When testing, keep in mind that enabling OIDC will make some tests fail. Please set the local auth in
proxy.config.jsontoenabled: true(andopenidconnecttoenabled: false) to make tests pass. Thank you!Changelog