forked from finos/git-proxy
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implements remote config support and config reload feature #14
Open
dcoric
wants to merge
2
commits into
main
Choose a base branch
from
denis-coric/remote-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df0f681
to
f8ba062
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
f8ba062
to
d9b5b5f
Compare
72fb681
to
b6737c9
Compare
2a66b4a
to
aa0283d
Compare
aa0283d
to
8d161a6
Compare
7dea019
to
55ce8ee
Compare
fix: config loader clone command issue fix: adds input validation, uses array arguments, prevented shell spawn fix: adds failsafe checking for directory location and structure fix: env-paths change to v2.2.1 which support require and minor code fix fix: improves test coverage Adds additional tests for better cove fix: fixed creating cache directory
7f0a5cf
to
a73338d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the GitProxy configuration management, including the ability to reload configurations dynamically without restarting the service, and support for multiple configuration sources. The key changes are:
config.schema.json
andproxy.config.json
, including file, HTTP, and Git sourcesConfigLoader
class insrc/config/ConfigLoader.js
to handle loading and merging configurations from different sources, with support for periodic reloads.src/config/index.js
to use the newConfigLoader
for managing configuration updates and reloading.reload-config
command to the CLI inpackages/git-proxy-cli/index.js
to trigger configuration reloads.src/service/index.js
to reload the configuration and restart services.