Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): enable multiple auth methods #24

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

jescalada
Copy link
Collaborator

@jescalada jescalada commented Feb 16, 2025

This PR enables multiple auth methods and sets the groundwork for adding a JWTStrategy to passport, as mentioned in #1, so we can have an extra security layer for the API.

I opened this PR to keep track of my work. I'll most likely end up closing and reopening it in the Finos repo. Sorry about that!

@jescalada jescalada self-assigned this Feb 16, 2025
@jescalada jescalada changed the title Enable multiple auth methods feat(auth): enable multiple auth methods Mar 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 59.52381% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@585cda6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/service/passport/activeDirectory.js 15.38% 22 Missing ⚠️
src/service/passport/local.js 80.76% 5 Missing ⚠️
src/service/passport/oidc.js 33.33% 4 Missing ⚠️
src/service/routes/auth.js 66.66% 2 Missing ⚠️
src/config/index.js 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   62.34%           
=======================================
  Files           ?       50           
  Lines           ?     1819           
  Branches        ?        0           
=======================================
  Hits            ?     1134           
  Misses          ?      685           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

renovate bot and others added 5 commits March 26, 2025 10:40
…-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…ples-manager

chore(deps): update dependency @finos/git-proxy to ^1.9.3 - git-proxy-plugin-samples - plugins/git-proxy-plugin-samples/package.json
fix(deps): update dependency axios to ^1.8.4 - git-proxy-cli - packages/git-proxy-cli/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants