-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ts): migrate config
module to use TS and ESM
#31
base: main
Are you sure you want to change the base?
refactor(ts): migrate config
module to use TS and ESM
#31
Conversation
config
module to use TS and ESMconfig
module to use TS and ESM
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage ? 50.99%
=======================================
Files ? 48
Lines ? 1655
Branches ? 81
=======================================
Hits ? 844
Misses ? 794
Partials ? 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…ples-manager chore(deps): update dependency @finos/git-proxy to ^1.9.3 - git-proxy-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…es/git-proxy-cli/package.json
fix(deps): update dependency axios to ^1.8.4 - git-proxy-cli - packages/git-proxy-cli/package.json
This PR builds on my previous refactoring PR (#27) to migrate
/src/config
files to TS and ESM. I modified the logic insrc/config/file.ts
to work with ESM imports. When usingget
/set
exports, these don't actually refresh unless explicitly exporting the desired variable (in this case,configFile
).*Note: * I investigated the
ERR_REQUIRE_ESM
error in the CI, which for some reason, works just fine when executingnpm run test-coverage-ci
locally. Apparently, this is expected when mixing ESM and CommonJS code in the same module. Source*Note 2: * My fix for the CI issues with ESM/TS was simply removing the dependency with the parent package (by copying the line where the environment variables are fetched). We might face the issue again when migrating the CLI to ESM/TS (if this is a priority).
Changelog
/src/config/
to use TS and ESM