This repository was archived by the owner on Jun 11, 2022. It is now read-only.
Add alt and class #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| %s(tiny@2x) => "640x", | ||
| %s(small@2x) => "960x", | ||
| %s(medium@2x) => "1536x", | ||
| %s(large@2x) => "2000x", | ||
| %s(large@2x) => "3200x" |
There was a problem hiding this comment.
Why are there two large@2x's? I think that may want to be changed to huge?
| To add a class to the picture tag: | ||
|
|
||
| ```erb | ||
| <%= picture_tag(image_path, picture_class: "some_class"}) %> |
There was a problem hiding this comment.
@levibrown I think it would be better if this behaved like image_tag. Namely, the html class and alt should be passed in options with keys class and alt. http://api.rubyonrails.org/classes/ActionView/Helpers/AssetTagHelper.html#method-i-image_tag
|
I added a commit to fix the readme large/huge typo. @jlsuttles, thoughts on the rest of the PR? |
|
@levibrown Hey! Are you using this branch? We should probably get it merged in. |
|
@jlsuttles As far as I know nobody is using this branch. Should be good to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds alt attr to the picture tag element and the ability to add a class.