Skip to content

Conversation

@luisheb
Copy link
Contributor

@luisheb luisheb commented Jun 14, 2025

Describe the proposed changes

FPCA basis added to facilitate its creation without having to use a custom basis.

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code conforms to the style used in this package
  • The code is fully documented and typed (type-checked with Mypy)
  • I have added thorough tests for the new/changed functionality

@luisheb
Copy link
Contributor Author

luisheb commented Jun 16, 2025

I haven’t added any tests for this new functionality, as it didn’t seem strictly necessary for this implementation. That said, if you think tests should be included, I’m happy to add them.

@luisheb luisheb marked this pull request as ready for review June 16, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant