Skip to content

Conversation

@Diegussa
Copy link
Contributor

References to issues or other PRs

Fixes #603

Describe the proposed changes

Minor changes to the default values of BaseKMeans init and FuzzyCMeans init from 0 to None.

random_state: RandomStateLike = None

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code conforms to the style used in this package
  • The code is fully documented and typed (type-checked with Mypy)
  • I have added thorough tests for the new/changed functionality

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.04%. Comparing base (e44d8e5) to head (7cd6ae2).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #704   +/-   ##
========================================
  Coverage    87.04%   87.04%           
========================================
  Files          199      199           
  Lines        14639    14639           
========================================
  Hits         12742    12742           
  Misses        1897     1897           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos. Please fix it and try to squash the changes in one commit using git rebase -i, as the latter commits are just fixes.

@Diegussa Diegussa force-pushed the fix_KMeans_random_state branch from ccf08ac to d2c2543 Compare October 29, 2025 11:50
Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnmabus vnmabus merged commit e7b921d into GAA-UAM:develop Oct 31, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default random_state for KMeans and FuzzyCMeans should be None

2 participants