김채원 API 코드 구현#12
Open
chaechaek1m wants to merge 1 commit intoGDSC-PKNU-Official:mainfrom
Open
Conversation
coke98
reviewed
Jun 23, 2024
Contributor
coke98
left a comment
coke98
left a comment
There was a problem hiding this comment.
다양한 구현을 원하긴했는데, book과 user 도메인이 이름 이외에는 다른 구조가 없어 아쉬웠어요. 다음 과제에서 더 기대해보겠습니다! 고생하셨습니다~
| public class UserController { | ||
| private List<User> users = new ArrayList<>(); | ||
|
|
||
| @GetMapping("/get") |
Contributor
There was a problem hiding this comment.
이미 GET메서드가 URL에서 명시한 자원을 가져온다라는 의미가 있기에
GET메서드와 중복되게 /users/get, add를 써야할지 한번 고민해봐도 좋을 것 같아요
|
|
||
| public User() { | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
바인딩과 기본 생성자 관련한 문제는 다른 분들도 많이 겪으신 것 같네요
채원님께서도 이번에 잘 기록해두었으니 다음에 잘 활용해주세요~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserController: 사용자 추가, 조회
BookController: 책 제목 추가, 조회