Skip to content

Yujeongkwon#7

Open
yujeongkwon wants to merge 13 commits intoGDSC-PKNU-Official:mainfrom
yujeongkwon:yujeongkwon
Open

Yujeongkwon#7
yujeongkwon wants to merge 13 commits intoGDSC-PKNU-Official:mainfrom
yujeongkwon:yujeongkwon

Conversation

@yujeongkwon
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@nuyh99 nuyh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고네요

Comment thread docs/README.md
@@ -0,0 +1,27 @@
## 입/출력
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하시네요!

Comment thread src/main/domain/Cash.java
public class Cash implements Payment{
private int cashInput = 0;

public void injectionCash(int inputOption) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메서드 명은 동사로 하면 좋을 것 같아요!

Comment thread src/main/domain/Cash.java
import java.util.Arrays;

public class Cash implements Payment{
private int cashInput = 0;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI와 도메인이 커플링이 커보이는데 괜찮을까요?!

Comment on lines +13 to +21
public static int readBeverageOption(Scanner scanner) {
System.out.print("사용자 입력 >");
return scanner.nextInt();
}

public static int readBeverageNumber(Scanner scanner) {
System.out.print("사용자 입력 >");
return scanner.nextInt();
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

분리했을 때 장단점이 어떻게 될까요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants