Skip to content

Conversation

@saqibns
Copy link
Contributor

@saqibns saqibns commented Nov 2, 2021

Added a default argument to enable the instantiation of the ToxicityFilter class without providing any arguments. This was required because the evaluation interface for robustness lacks the option of providing custom options for instantiating classes.

@AbinayaM02 AbinayaM02 added enhancement New feature or request filter labels Nov 25, 2021
Copy link
Collaborator

@AbinayaM02 AbinayaM02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saqibns: Thank you for adding this enhancement. Please pull the main once and we can merge your changes.

tasks = [TaskType.TEXT_TO_TEXT_GENERATION]
languages = ["en"]
heavy = True

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you can add docstring for your classes and functions.

languages = ["en"]
heavy = True

def __init__(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add keywords for your filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request filter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants